layout: Only show ripple animation when overview was toggled

On X11, clients can grab keyboard on pointer (for example for popup
menus), and as a result the pushModal() call when opening the overview
fails.

However when the hot corner was used to toggle the overview, we still
show the ripple animation in that case, which is confusing as the action
did not actually happen.

Fix this by only showing the ripples if the overview is animating after
calling toggle(), as that should be a reliable indication of whether
the call was successful.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3005

diff --git a/js/ui/layout.js b/js/ui/layout.js
index d37c769409c672f8574d2bfc4794d0bac00c6722..b082ec80b02a29bfdfb410f342beef44aac60f5c 100644 (file)
--- a/js/ui/layout.js
+++ b/js/ui/layout.js
@@ -1228,8 +1228,9 @@ class HotCorner extends Clutter.Actor {
             return;
 
         if (Main.overview.shouldToggleByCornerOrButton()) {
-            this._ripples.playAnimation(this._x, this._y);
             Main.overview.toggle();
+            if (Main.overview.animationInProgress)
+                this._ripples.playAnimation(this._x, this._y);
         }
     }